Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aksel.nav.no] Add cookie prompt #3469

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[aksel.nav.no] Add cookie prompt #3469

wants to merge 2 commits into from

Conversation

HalvorHaugan
Copy link
Contributor

A quick draft of how we could do it. Not done by any means, we also need a way for people to change the setting.

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: c892e44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,5 +1,6 @@
import type { Types } from "@amplitude/analytics-browser";
import { useEffect } from "react";
import { useCookies } from "react-cookie";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to just use "document.cookie"? useCookies is just a wrapper for "universal-cookies" that uses document.cookie and parses it

Copy link
Contributor Author

@HalvorHaugan HalvorHaugan Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. I just threw this together in a hurry. At first glance, it looked cumbersome to use document.cookie directly, but it might not be that cumbersome if I just learn how to.

@larseirikhansen larseirikhansen added the On hold ⏸️ PR is on hold, no need for review yet! label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On hold ⏸️ PR is on hold, no need for review yet!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants